More data to download for demo (sea-ice model example files added)#1366
Merged
Conversation
Contributor
Author
|
Hi @kristinchang3, when you get a chance, could you run demo 0, 9, 9b with this PR and see if any error arise? They run okay on my end but wanted to make sure before getting the update merged to the main branch. |
kristinchang3
approved these changes
May 27, 2026
kristinchang3
left a comment
kristinchang3
left a comment
Collaborator
There was a problem hiding this comment.
Hi @lee1043 looks good to me! The code runs well with the new data and plots are showing results for just the 2010-2014 time period.
Contributor
Author
|
Excellent, thank you @kristinchang3 for checking it promptly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @gleckler1, model sample data for sea-ice (sic, areacello of E3SM-1-0) were added for demo 0 that downloads files for demo notebooks